Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new contextBridge module #20307
feat: add a new contextBridge module #20307
Changes from all commits
5c4c9d5
64fa6f3
4b79d73
50c3dfd
4fe3eb6
1104711
f308827
291e71e
dc170d4
e897664
7d652be
07a87bc
fe23ca3
1f9312a
cce347c
c1d1ae0
8ad78c0
403cb0e
de67801
d568dac
a433905
1fb7e4d
42c31cb
2b9cbf2
8573d0f
8868b76
ed8a8c2
c57c8ae
7306cfe
03c1cd9
3c77df0
bb41a56
785bc2f
33b598d
6b05ca0
b7b23ae
7aa9d80
5a5548e
55bbdac
84598b8
7913f52
a4a5af1
4475a88
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a short paragraph explaining why the reader might want to use this. What problems does this solve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't get addressed...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since contextIsolation is mentioned in a BW constructor option and isn't super obvious from just a link to
browser-window.md
that it would be worthwhile to lower that barrier and re-copy it here or move it into a standalone document we could link toThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about
Date
,RegExp
,ArrayBuffer
,ArrayBufferView
? those are now natively supported by the IPC payload serializer. It would be nice if they were supported here as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe reference https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are already supported, just need to put them or structured clone into this table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this to point to SCA probably.