Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adds Use system dialogs Fiddle example #20473

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

yashints
Copy link
Contributor

@yashints yashints commented Oct 8, 2019

Description of Change

Refs #20442

Adds all the Use system dialogs:
✅ Open a file or directory
✅ Error dialog
✅ Information dialog
✅ Save dialog
examples from electron-api-demos into a runnable Fiddle example.

Checklist

  • PR description included and stakeholders cc'd
  • standard linter passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: Added the Use system dialogs example from electron-api-demos into a runnable Fiddle example.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 8, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 9, 2019
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency's sake, could you break this down into 1 Fiddle per demo?

Also:

  • Make links open in new browser window with shell.openExternal
  • Remove obsolete CSS classes

@yashints
Copy link
Contributor Author

Applied all of the above changes

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm following changes

@codebytere codebytere merged commit b060cbf into electron:master Oct 31, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 31, 2019

Release Notes Persisted

Added the Use system dialogs example from electron-api-demos into a runnable Fiddle example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants