Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint patch descriptions #20919

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@nornagon
Copy link
Member

nornagon commented Nov 1, 2019

Description of Change

We have a policy that all patches need to come with justification for their existence. This will help us enforce that policy.

Checklist

Release Notes

Notes: none

@nornagon nornagon requested a review from MarshallOfSound Nov 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 2, 2019
@miniak
miniak approved these changes Nov 3, 2019
@nornagon nornagon merged commit 4de04da into master Nov 4, 2019
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191101.28 succeeded
Details
electron-arm64-testing Build #20191101.28 succeeded
Details
electron-woa-testing Build #20191101.18 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 4, 2019

No Release Notes

@nornagon nornagon deleted the lint-patch-descriptions branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.