feat: add win.getBackgroundColor() for macOS

[vbennich]

Description of Change

Added a win.getBackgroundColor() to get the backgroundColor for a BrowserWindow in MacOS. The value could be set by win.setBackgroundColor(color), and it would be logical to have a getter. Inspired by #20203.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added win.getBackgroundColor() for BrowserWindow on macOS.

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[vbennich]

I have unintentionally added some code that tries (miserably) to get the backgroundColor on Linux and breaks the build for Linux. I will triangulate and remove that code and update the pull request to make it buildable on all platforms.

[codebytere]

@vbennich it looks like some git debris got left in there too - once that's removed and the checks are green just @ me and i'll give this a review.

[vbennich]

Seems like it passes all checks and it works for now. @codebytere please have a look at this, and thank you for your help :)

[codebytere]

Looking good so far - just a few things to get this moving forward :)

[vbennich]

I don't know why the electron test failed for win-ia32-testing-pr. Will try to commit for another build. The log where the error occurred:

[01:15:12] ok 267 BrowserWindow module BrowserWindow.openDevTools() does not crash for frameless window [01:15:12] ok 268 BrowserWindow module BrowserWindow.fromBrowserView(browserView) returns the window with the browserView [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](118, 3), LocalSurfaceId(2, 1, A1B1...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](96, 3), LocalSurfaceId(2, 1, FCD6...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](92, 3), LocalSurfaceId(2, 1, 8A95...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](80, 9), LocalSurfaceId(2, 1, 53AF...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](127, 3), LocalSurfaceId(3, 1, A8E0...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](76, 3), LocalSurfaceId(2, 1, 47CD...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](84, 3), LocalSurfaceId(2, 1, AAE8...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](74, 3), LocalSurfaceId(2, 1, DB1C...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](82, 3), LocalSurfaceId(2, 1, 8711...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](90, 3), LocalSurfaceId(2, 1, 95DA...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](124, 3), LocalSurfaceId(3, 1, 3078...)) [01:15:15] [3784:1211/165624.471:ERROR:surface_manager.cc(438)] Old/orphaned temporary reference to SurfaceId(FrameSinkId[](101, 3), LocalSurfaceId(2, 1, 61D2...)) [01:15:23] ✗ Electron tests failed with code 0xc0000374. [01:15:23] error Command failed with exit code 1. [01:15:23] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. [01:15:23] Command exited with code 1

[codebytere]

@vbennich this looks like a flake and not a failure caused by your change; i'll rerun!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

Added win.getBackgroundColor() for BrowserWindow on macOS.