Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable pointer compression and 31bit smis #21468

Merged
merged 2 commits into from
Dec 13, 2019
Merged

feat: enable pointer compression and 31bit smis #21468

merged 2 commits into from
Dec 13, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Dec 10, 2019 •
edited
Loading

Closes #21464

Notes: Enabled V8 pointer compression.

@nornagon nornagon requested a review from a team as a code owner December 10, 2019 23:04
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 10, 2019
@deepak1556
Copy link
Member

Can we align the patch based on nodejs/node@dda658c , so that we only have to enable the gyp variables and the definitions part need not be maintained.

@nornagon nornagon changed the base branch from roller/chromium/master to master December 11, 2019 19:02
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 11, 2019
@nornagon
Copy link
Member Author

@deepak1556 done, sort of. I'm not sure if I got the gyp syntax correct, but presumably CI will tell me :D

deepak1556
deepak1556 approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nornagon
Copy link
Member Author

CI is flake

@nornagon nornagon merged commit c535e00 into master Dec 13, 2019
@release-clerk
Copy link

release-clerk bot commented Dec 13, 2019

Release Notes Persisted

Enabled V8 pointer compression.

@nornagon nornagon deleted the ptr-compression branch December 13, 2019 18:12
@deepak1556 deepak1556 mentioned this pull request May 13, 2020
Closed
@heylying heylying mentioned this pull request Oct 19, 2021
Open
3 tasks
@masa-nuc masa-nuc mentioned this pull request Apr 29, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable pointer compression and 31 bit smis
3 participants
@nornagon @deepak1556 @MarshallOfSound