fix: quit after Chromium is fully started #21488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
changed the title
zcbenz
force-pushed
the
fix-woa-crash-exit
branch
from
fffa366
to
8609c38
Compare
zcbenz
changed the title
zcbenz
changed the title
zcbenz
force-pushed
the
fix-woa-crash-exit
branch
from
53e9030
to
8609c38
Compare
zcbenz
force-pushed
the
fix-woa-crash-exit
branch
from
8609c38
to
5810321
Compare
nornagon
reviewed
Dec 12, 2019
nornagon
approved these changes
Dec 12, 2019
MarshallOfSound
approved these changes
Dec 13, 2019
deepak1556
approved these changes
Dec 13, 2019
|
The |
|
No Release Notes |
This was referenced Dec 13, 2019
|
I have automatically backported this PR to "7-1-x", please check out #21505 |
|
I have automatically backported this PR to "6-1-x", please check out #21506 |
|
I have automatically backported this PR to "8-x-y", please check out #21507 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Flush pending tasks before quitting Electron.
This is to fix crash on exit which happens when Electron quits while there are still some initialization work pending in message loop.
This should be able to fix some flaky tests on CI.
This does not completely fix the flaky tests that destroy WebContents, which I believe have other reasons for crashing.
Release Notes
Notes: no-notes