Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sourcemaps over file:// not loading with network service #21494

Conversation

@trop
Copy link
Contributor

trop bot commented Dec 12, 2019

Backport of #21473

See that PR for details.

Notes: fix source maps not loading in devtools with file scheme

@trop trop bot requested a review from deepak1556 Dec 12, 2019
@trop trop bot mentioned this pull request Dec 12, 2019
4 of 6 tasks complete
@trop trop bot added 7-1-x backport labels Dec 12, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 12, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Dec 12, 2019

not ok 588 Menu module Menu.setApplicationMenu does not override null menu on startup
  Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\vsts-agent-win-x86-2.148.2\_work\1\s\src\electron\spec-main\api-menu-spec.ts)
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

seems unrelated but also is concerning cc @zcbenz

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Dec 12, 2019

seems unrelated but also is concerning cc @zcbenz

#21488 should be able to fix this flaky test.

@deepak1556 deepak1556 merged commit 96e7b44 into 7-1-x Dec 13, 2019
17 of 19 checks passed
17 of 19 checks passed
electron-woa-testing Build #20191212.13 had test failures
Details
electron-woa-testing #20191212.13 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191212.13 succeeded
Details
electron-arm-testing #20191212.13 succeeded
Details
electron-arm64-testing Build #20191212.13 succeeded
Details
electron-arm64-testing #20191212.13 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 13, 2019

Release Notes Persisted

fix source maps not loading in devtools with file scheme

@deepak1556

This comment has been minimized.

Copy link
Member

deepak1556 commented Dec 13, 2019

Failures are unrelated, merging.

@deepak1556 deepak1556 deleted the trop/7-1-x-bp-fix-sourcemaps-over-file-not-loading-with-network-service-1576137511066 branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.