Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlight buttons correctly when defaultId passed #21652

Conversation

@trop
Copy link
Contributor

trop bot commented Dec 31, 2019

Backport of #21642

See that PR for details.

Notes: Fixed incorrect button highlighting when defaultId is passed for dialog message boxes.

@trop trop bot requested a review from codebytere Dec 31, 2019
@trop trop bot mentioned this pull request Dec 31, 2019
4 of 4 tasks complete
@trop trop bot added 7-1-x backport labels Dec 31, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 31, 2019
@codebytere codebytere merged commit e0576ef into 7-1-x Jan 3, 2020
13 of 16 checks passed
13 of 16 checks passed
electron-arm-testing Build #20191231.6 failed
Details
electron-arm64-testing Build #20191231.6 failed
Details
electron-woa-testing Build #20191231.5 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 3, 2020

Release Notes Persisted

Fixed incorrect button highlighting when defaultId is passed for dialog message boxes.

@codebytere codebytere deleted the trop/7-1-x-bp-fix-highlight-buttons-correctly-when-defaultid-passed-1577800145146 branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.