fix: don't unnecessarily copy draggable regions #21704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some calls to
BrowserWindow::UpdateDraggableRegions
the parameterregions
points to object's variabledraggable_regions_
which we latertry to update with data received in the parameter. In these cases coping
is unnecessary. Additionally after this code is executed
draggable_regions_
would be empty and as a result whole window would be undraggable.
In our project which uses Electron it's possible to create frameless window
which doesn't repect css option
webkit-app-region: drag
and is undraggablebecause of this problem but it would be hard to create one for clean
Electron.
Description of Change
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue that could cause frameless windows to become undraggable in some circumstances.