build: strip zip determinism on artifact upload

[thypon]

Description of Change

Since electron zip are including build dates the checksum of each of
these zip files is time dependant. In order to fix this issue strip all
the dates contained in each of the zip entries.

See: #21327 and 97959b5 , cont #20949

Cc: @nornagon @felixrieseberg @ikkisoft

Checklist

• PR description included and stakeholders cc'd
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Strip non-determinism from zip release files

[nornagon]

Can we instead set the date to something deterministic when we create the zip file? e.g. the date from the commit?

[thypon]

It should be possible to set whichever date we choose, however all the existing tooling tend to assume the minimum epoch time settable in a zip as the default https://salsa.debian.org/reproducible-builds/strip-nondeterminism/blob/master/lib/File/StripNondeterminism/handlers/zip.pm#L200 . If we stick with that convention we will get free external tooling support for checking.

[nornagon]

@thypon in particular, I meant, can we set the date/time on the zip file when we create it, rather than after the fact? I think we could do so by setting date_time on a ZipInfo object: https://docs.python.org/3/library/zipfile.html#zipinfo-objects

[thypon]

I meant, can we set the date/time on the zip file when we create it, rather than after the fact?

Ah that should be the case, yep.

My upload pass covers every case of zip file created, even when we don't directly control the zip creation. Moreover since it is located a step before uploading the release it also opens up for other future metadata removal (eg. OS version header or zero length trailers).

[nornagon]

Hm, ok, seems reasonable. Zip format probably won't change from underneath us I hope :)

[zcbenz]

@thypon Do you mind rebasing this PR on latest master? The macOS CI is failing because of an already fixed issue, rebasing on master should be able to turn it to green.

[thypon]

Done, let's wait!

[jkleinsc]

Release builds running here:
AppVeyor release build request for electron-x64 successful. Check build status at https://ci.appveyor.com/project/electron-bot/electron-x64-release/build/1.0.457
AppVeyor release build request for electron-ia32 successful. Check build status at https://ci.appveyor.com/project/electron-bot/electron-ia32-release/build/1.0.425
AppVeyor release build request for electron-woa successful. Check build status at https://ci.appveyor.com/project/electron-bot/electron-woa-release/build/1.0.249
CircleCI release build request for linux-ia32-publish successful. Check https://circleci.com/gh/electron/electron/444457 for status.
CircleCI release build request for mas-publish successful. Check https://circleci.com/gh/electron/electron/444459 for status.
CircleCI release build request for osx-publish successful. Check https://circleci.com/gh/electron/electron/444458 for status.
CircleCI release build request for linux-arm64-publish successful. Check https://circleci.com/gh/electron/electron/444460 for status.
CircleCI release build request for linux-arm-publish successful. Check https://circleci.com/gh/electron/electron/444461 for status.
CircleCI release build request for linux-x64-publish successful. Check https://circleci.com/gh/electron/electron/444462 for status.

[jkleinsc]

Looks like this change is erroring out with:

 File "script\release\uploaders\upload.py", line 277, in <module>
    sys.exit(main())
  File "script\release\uploaders\upload.py", line 73, in main
    upload_electron(release, electron_zip, args)
  File "script\release\uploaders\upload.py", line 213, in upload_electron
    _zero_zip_date_time(file_path)
  File "script\release\uploaders\upload.py", line 175, in _zero_zip_date_time
    archive_size = os.fstat(zip_.fileno()).st_size
AttributeError: 'str' object has no attribute 'fileno'
Command executed with exception:   File "script\release\uploaders\upload.py", line 277, in <module>
    sys.exit(main())
  File "script\release\uploaders\upload.py", line 73, in main
    upload_electron(release, electron_zip, args)
  File "script\release\uploaders\upload.py", line 213, in upload_electron
    _zero_zip_date_time(file_path)
  File "script\release\uploaders\upload.py", line 175, in _zero_zip_date_time
    archive_size = os.fstat(zip_.fileno()).st_size
AttributeError: 'str' object has no attribute 'fileno'

eg see https://ci.appveyor.com/project/electron-bot/electron-ia32-release/builds/30316079

[thypon]

Seems to be ok now

[jkleinsc]

Release builds running here:
AppVeyor release build request for electron-ia32 successful. Check build status at https://ci.appveyor.com/project/electron-bot/electron-ia32-release/build/1.0.430
AppVeyor release build request for electron-x64 successful. Check build status at https://ci.appveyor.com/project/electron-bot/electron-x64-release/build/1.0.462
AppVeyor release build request for electron-woa successful. Check build status at https://ci.appveyor.com/project/electron-bot/electron-woa-release/build/1.0.254
CircleCI release build request for linux-ia32-publish successful. Check https://circleci.com/gh/electron/electron/448688 for status.
CircleCI release build request for linux-arm64-publish successful. Check https://circleci.com/gh/electron/electron/448691 for status.
CircleCI release build request for linux-arm-publish successful. Check https://circleci.com/gh/electron/electron/448690 for status.
CircleCI release build request for mas-publish successful. Check https://circleci.com/gh/electron/electron/448689 for status.
CircleCI release build request for osx-publish successful. Check https://circleci.com/gh/electron/electron/448692 for status.
CircleCI release build request for linux-x64-publish successful. Check https://circleci.com/gh/electron/electron/448693 for status.

[jkleinsc]

Merging as CI failures unrelated to PR change.

[release-clerk]

Release Notes Persisted

Strip non-determinism from zip release files