Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exposing methods required by capturing a hidden webContents #21895

Merged
merged 1 commit into from Jan 31, 2020

Conversation

@LuoJinghua
Copy link
Contributor

@LuoJinghua LuoJinghua commented Jan 25, 2020

Description of Change

Backport of #21679 for the 8-x-y branch.

Release Notes
Notes: Exposing methods required by capturing a hidden webContents

@zcbenz

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Features can not be backported to older release lines without approval from @electron/wg-releases

Loading

@zcbenz
Copy link
Member

@zcbenz zcbenz commented Jan 27, 2020

@LuoJinghua I have added this to next wg-releases meeting's agenda, but we need to have a strong reason when backporting a new feature. Can you explain why you want to backport this feature?

Loading

@LuoJinghua
Copy link
Contributor Author

@LuoJinghua LuoJinghua commented Jan 27, 2020

@LuoJinghua I have added this to next wg-releases meeting's agenda, but we need to have a strong reason when backporting a new feature. Can you explain why you want to backport this feature?

Hi @zcbenz,

Our product shows a wall of browsers, user can click one of them to show the browser window and then hide the window. The product need this API to function correctly without any other workaround. We really don't want to depend on the electron nightly or build a custom version of electron from stable branch. These methods existed for a long time and just isn't exposed. Without this backport, we have to a build custom version of electron until electron-9 become stable.

Loading

@LuoJinghua LuoJinghua force-pushed the hidden-capture-8-x-y branch from 3c6c77e to 11d0ac0 Jan 27, 2020
@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Jan 29, 2020

The @electron/wg-releases WG has decided that this feature is too late to make it into the 8-0-x release. It will be included in a 8-1-x release if the decision is made to issue a 8-1-x release. We are going to move this PR to a WIP status in the meantime.

Loading

@jkleinsc jkleinsc changed the title feat: Exposing methods required by capturing a hidden webContents [WIP] feat: Exposing methods required by capturing a hidden webContents Jan 29, 2020
@MarshallOfSound MarshallOfSound changed the title [WIP] feat: Exposing methods required by capturing a hidden webContents feat: Exposing methods required by capturing a hidden webContents Jan 31, 2020
@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Jan 31, 2020

This feature was re-visited by the @electron/wg-releases on 31/01/2020 and approved for merge to 8-x-y

Loading

@MarshallOfSound MarshallOfSound merged commit 46a4864 into electron:8-x-y Jan 31, 2020
10 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 31, 2020

Release Notes Persisted

Exposing methods required by capturing a hidden webContents

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants