-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Exposing methods required by capturing a hidden webContents #21679
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Could you please review my changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add documentations for the methods?
Ok, no problem. |
0361991
to
4a3fcd2
Compare
@zcbenz Could you please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, would like to get more inputs from @electron/wg-api.
4a3fcd2
to
108681d
Compare
108681d
to
1857de3
Compare
@codebytere I have fixed all issues and pushed to my branch, could you please review my changes again. |
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
@LuoJinghua has manually backported this PR to "7-1-x", please check out #21894 |
@LuoJinghua has manually backported this PR to "8-x-y", please check out #21895 |
@LuoJinghua has manually backported this PR to "7-2-x", please check out #21894 |
is this available for 6.1.x ? |
Description of Change
This pull request adds methods required by capturing a hidden webContents. With the IncrementCapturerCount(), it's possible to capture screen shot of BrowserView which attached to
a hidden BrowserWindow.
cc @MarshallOfSound @ckerr @zcbenz
Checklist
npm test
passesRelease Notes
notes: Exposing methods required by capturing a hidden webContents。