Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revive offscreen rendering support #22431

Merged
merged 3 commits into from
Mar 31, 2020
Merged

fix: revive offscreen rendering support #22431

merged 3 commits into from
Mar 31, 2020

Conversation

jkleinsc
Copy link
Contributor

Description of Change

Backport of #22160.

See that PR for details.

Checklist

Release Notes

Notes: Enable offscreen rendering

@jkleinsc jkleinsc requested a review from a team as a code owner February 27, 2020 20:12
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 27, 2020
@trop trop bot mentioned this pull request Feb 27, 2020
Merged
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Feb 27, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 28, 2020
@jkleinsc jkleinsc force-pushed the backport-22160-8 branch 3 times, most recently from 5e5b757 to b8f7ad5 Compare March 4, 2020 21:26
@zcbenz
Copy link
Contributor

zcbenz commented Mar 6, 2020

Can you rebase the branch to fix the merge conflict?

codebytere
codebytere previously approved these changes Mar 10, 2020
View reviewed changes
@codebytere codebytere dismissed their stale review March 10, 2020 17:06

meant to comment

@codebytere
Copy link
Member

@jkleinsc the CI failures on Linux are related and deterministic i believe

@jkleinsc
Copy link
Contributor Author

@zcbenz @codebytere I dug into the failing tests a little more and @adill did as well. It turns out that the tests run fine in 32 bit linux if you have a display and are not using Xvfb for headless testing. Therefore, I disabled the tests for 32-bit linux.

@jkleinsc jkleinsc merged commit a4d8974 into 8-x-y Mar 31, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 31, 2020

Release Notes Persisted

Enable offscreen rendering

@jkleinsc jkleinsc deleted the backport-22160-8 branch March 31, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkleinsc @zcbenz @codebytere