Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport d82a02c837d3 from WebRTC. #23037

Merged

Conversation

@ppontes
Copy link
Member

@ppontes ppontes commented Apr 8, 2020

Description of Change

ACM: Corrected temporary buffer size

This CL corrects the temporary buffers size in the
pre-processing of the capture audio before encoding.

As part of this it removes the ACM-specific hardcoding
of the size and instead ensures that the size of the
temporary buffer matches that of the AudioFrame.

Bug: webrtc:11242 / chromium: 1060647
Change-Id: I56dd6cadfd4e140e8e159966c33d1027383ea9fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170340
Commit-Queue: Per Åhgren peah@webrtc.org
Reviewed-by: Henrik Lundin henrik.lundin@webrtc.org
Reviewed-by: Henrik Andreassson henrika@webrtc.org
Cr-Commit-Position: refs/heads/master@{#30775}

Release Notes

Notes: Security: backported fix for a potential buffer overrun in WebRTC audio encoding.

@ppontes ppontes requested a review from Apr 8, 2020
@ppontes ppontes requested a review from as a code owner Apr 8, 2020
ACM: Corrected temporary buffer size

This CL corrects the temporary buffers size in the
pre-processing of the capture audio before encoding.

As part of this it removes the ACM-specific hardcoding
of the size and instead ensures that the size of the
temporary buffer matches that of the AudioFrame.
@ppontes ppontes force-pushed the origin/ppontes/backport-webrtc-d82a02c837d3-to-7-2-x branch from 70a5cd3 to a69a970 Apr 9, 2020
@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Apr 13, 2020

Merging as CI failure is known flake unrelated to this PR.

@jkleinsc jkleinsc merged commit 5dac453 into 7-2-x Apr 13, 2020
15 of 16 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 13, 2020

Release Notes Persisted

Security: backported fix for a potential buffer overrun in WebRTC audio encoding.

@jkleinsc jkleinsc deleted the origin/ppontes/backport-webrtc-d82a02c837d3-to-7-2-x branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants