Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add app.configureHostResolver #30775

Merged
merged 2 commits into from
Sep 2, 2021
Merged

feat: add app.configureHostResolver #30775

merged 2 commits into from
Sep 2, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 31, 2021

Backport of #30576

See that PR for details.

Notes: Added app.configureHostResolver API for configuring DNS-over-HTTPS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2021
@trop trop bot requested a review from nornagon August 31, 2021 18:55
@trop trop bot mentioned this pull request Aug 31, 2021
Merged
5 tasks
@trop trop bot added 15-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Aug 31, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2021
jkleinsc
jkleinsc requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session module ses.setCertificateVerifyProc tests are failing with this PR and need to be resolved before merging this.

MarshallOfSound
MarshallOfSound approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases

MarshallOfSound
MarshallOfSound approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases

@jkleinsc jkleinsc merged commit 4fb3b58 into 15-x-y Sep 2, 2021
@jkleinsc jkleinsc deleted the trop/15-x-y-bp-feat-add-app-configurehostresolver-1630436152109 branch September 2, 2021 00:22
@release-clerk
Copy link

release-clerk bot commented Sep 2, 2021

Release Notes Persisted

Added app.configureHostResolver API for configuring DNS-over-HTTPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
15-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nornagon @jkleinsc @MarshallOfSound