Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't assign NSAlert to window which is not visible #23089

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Apr 13, 2020

Backport of #22672

See that PR for details.

Notes: Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS.

docs/api/dialog.md Outdated Show resolved Hide resolved
@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Apr 14, 2020

Merging as CI failures are unrelated to PR changes.

@jkleinsc jkleinsc merged commit 97010bf into 7-2-x Apr 14, 2020
14 of 16 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 14, 2020

Release Notes Persisted

Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS.

@jkleinsc jkleinsc deleted the trop/7-2-x-bp-fix-don-t-assign-nsalert-to-window-which-is-not-visible-1586766420318 branch Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants