Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 86c02c5dcd37 from chromium #23526

Merged
merged 4 commits into from
May 13, 2020
Merged

chore: cherry-pick 86c02c5dcd37 from chromium #23526

merged 4 commits into from
May 13, 2020

Conversation

belenko
Copy link

@belenko belenko commented May 12, 2020

Security backport: https://chromium-review.googlesource.com/c/chromium/src/+/2122057

[Autofill] Fixed requesting invalid country codes from CountryData.

Change-Id: Id0ce647400bdce2eb4cdd358432b7c647f880570
Bug: 1062861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122057
Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#758887}

Notes: Security: Backport Chromium fix for https://crbug.com/1062861

@belenko belenko requested a review from a team as a code owner May 12, 2020 13:32
@welcome
Copy link

welcome bot commented May 12, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 12, 2020
@nornagon nornagon added 6-1-x backport-check-skip Skip trop's backport validity checking labels May 12, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 13, 2020
@nornagon nornagon merged commit fc41789 into electron:6-1-x May 13, 2020
@welcome
Copy link

welcome bot commented May 13, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented May 13, 2020

Release Notes Persisted

Security: Backport Chromium fix for https://crbug.com/1062861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-1-x backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants