build: save mksnapshot args in Windows mksnapshot.zip #23634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
May 18, 2020
|
Merging as CI failure unrelated to this PR. |
|
No Release Notes |
|
I have automatically backported this PR to "9-x-y", please check out #23641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#21991 added
mksnapshot_argsto the mksnapshot zips for Linux and macOS but did not do so for Windows. electron/mksnapshot#27 updated the mksnapshot node module to use this args file to make sure mksnapshot is properly executed, so we need this file in the Windows zips as well.Checklist
npm testpassesRelease Notes
Notes: none