chore: update mksnapshot to work with arm*-x64 zips #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates this module to work correctly with our arm*-x64 zips which are used to generate snapshots for arm hardware from an Intel x64 machine. This is the only way to generate snapshots for ARM hardware.
Additionally, this resolves #23 as much as we can. If someone attempts to install this module on linux-armv7l, linux-arm64, or win32-arm64 an error message will be printed directing the user to download the x64 cross arch version of mksnapshot which can be used on an x64 machine to generate snapshots for those platforms.