Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read GTK dark theme setting on Linux #23678

Merged
merged 1 commit into from
May 21, 2020
Merged

fix: read GTK dark theme setting on Linux #23678

merged 1 commit into from
May 21, 2020

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented May 20, 2020 •
edited
Loading

Description of Change

Close #21427.

Chromium does not respect the dark theme settings from GTK, according to a Chromium issue it is intended and because of Chromium having its own settings of themes (custom theme, WebUI theme, forced dark theme).

This PR makes sure the default dark theme setting of Electron is synced with GTK.

I don't have a test for this though, since it involves desktop environment settings of the host machine. (We don't test dark theme for macOS neither.)

Release Notes

Notes: Fix GTK dark theme setting not respected in Electron on Linux.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 20, 2020
@zarubond zarubond mentioned this pull request May 20, 2020
Closed
3 tasks
@zcbenz zcbenz requested a review from deepak1556 May 20, 2020 23:44
deepak1556
deepak1556 approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 21, 2020
@MarshallOfSound MarshallOfSound merged commit fdf40ce into master May 21, 2020
@release-clerk
Copy link

release-clerk bot commented May 21, 2020

Release Notes Persisted

Fix GTK dark theme setting not respected in Electron on Linux.

@MarshallOfSound MarshallOfSound deleted the fix-linux-dark-theme branch May 21, 2020 22:41
@MarshallOfSound
Copy link
Member

/trop run backport-to 10-x-y

@trop
Copy link
Contributor

trop bot commented May 21, 2020

10-x-y is no longer supported - no backport will be initiated.

@MarshallOfSound
Copy link
Member

/trop run backport

@trop
Copy link
Contributor

trop bot commented May 21, 2020

The backport process for this PR has been manually initiated, here we go! :D

@MarshallOfSound
Copy link
Member

/trop run backport

@MarshallOfSound
Copy link
Member

/trop run backport-to 10-x-y

@trop
Copy link
Contributor

trop bot commented May 21, 2020

10-x-y is no longer supported - no backport will be initiated.

@trop trop bot mentioned this pull request May 21, 2020
Merged
@trop
Copy link
Contributor

trop bot commented May 21, 2020

I have automatically backported this PR to "9-x-y", please check out #23712

@trop trop bot added the in-flight/9-x-y label May 21, 2020
@jkleinsc
Copy link
Contributor

/trop run backport-to 10-x-y

@trop
Copy link
Contributor

trop bot commented May 21, 2020

The backport process for this PR has been manually initiated -
sending your commits to "10-x-y"!

@trop trop bot mentioned this pull request May 21, 2020
Closed
@trop
Copy link
Contributor

trop bot commented May 21, 2020

I have automatically backported this PR to "10-x-y", please check out #23718

@MarshallOfSound MarshallOfSound mentioned this pull request Jun 2, 2020
Closed
3 tasks
@codebytere
Copy link
Member

@zcbenz can this be backported to 8? It utilizes gtk_ui_delegate_ which doesn't exist on that branch.

@zcbenz
Copy link
Contributor Author

zcbenz commented Jun 4, 2020

It should be able to be backported, I'll take care of it.

zcbenz added a commit that referenced this pull request Jun 4, 2020
@zcbenz
fix: read GTK dark theme setting on Linux (#23678)
bd0a745
@zcbenz zcbenz mentioned this pull request Jun 4, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jun 4, 2020

@zcbenz has manually backported this PR to "8-x-y", please check out #23965

@zcbenz zcbenz mentioned this pull request Jun 4, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jun 4, 2020

@zcbenz has manually backported this PR to "7-3-x", please check out #23966

@ckerr ckerr mentioned this pull request Jun 4, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always matches prefers-color-scheme: light media-query (no dark mode)
5 participants
@zcbenz @MarshallOfSound @jkleinsc @codebytere @deepak1556