Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: volume key globalShortcut registration #23782

Merged
merged 1 commit into from
May 28, 2020
Merged

fix: volume key globalShortcut registration #23782

merged 1 commit into from
May 28, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Fixes a NOTREACHED DCHECK crash here borne of the fact that we patched MediaKeysListener::IsMediaKeycode and then did not add the three extra keys to the switch statement. Also adds the three missing keys to the Accessibility check.

Checklist

Release Notes

Notes: Fixed an issue with volume-related globalShortcut registration.

@codebytere codebytere requested a review from a team as a code owner May 27, 2020 05:46
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 27, 2020
deepak1556
deepak1556 requested changes May 27, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch application failed.

Side note: Can you also update the patch subject, it has outdated information about MPRemoteCommandCenter

@codebytere
Copy link
Member Author

@deepak1556 that was just the automatic patch linter failing, not the patch itself. Fixed!

deepak1556
deepak1556 approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 28, 2020
@jkleinsc jkleinsc merged commit 6516110 into master May 28, 2020
@release-clerk
Copy link

release-clerk bot commented May 28, 2020

Release Notes Persisted

Fixed an issue with volume-related globalShortcut registration.

@jkleinsc jkleinsc deleted the fix-volume-keys branch May 28, 2020 12:56
@trop
Copy link
Contributor

trop bot commented May 28, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

This was referenced May 28, 2020
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 28, 2020

I have automatically backported this PR to "10-x-y", please check out #23823

@trop
Copy link
Contributor

trop bot commented May 28, 2020

I have automatically backported this PR to "9-x-y", please check out #23824

@codebytere codebytere mentioned this pull request Jun 3, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jun 3, 2020

@codebytere has manually backported this PR to "8-x-y", please check out #23948

@alexeykuzmin alexeykuzmin mentioned this pull request Jun 5, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codebytere @jkleinsc @zcbenz @deepak1556