fix: nativeImage remote serialization #23797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.
* refactor: correctly serialize nativeImage/buffer with typeUtils * test: add serialization specs * fix: construct from dataURL * test: test for dataURL specificity
4 tasks
4 tasks
This was referenced May 27, 2020
codebytere
force-pushed
the
native-image-fixes-8
branch
from
c785ef2
to
e89190b
Compare
codebytere
force-pushed
the
native-image-fixes-8
branch
2 times, most recently
from
65e5a26
to
2cd96b1
Compare
codebytere
force-pushed
the
native-image-fixes-8
branch
from
2cd96b1
to
2cf09d4
Compare
jkleinsc
approved these changes
Jun 8, 2020
|
Release Notes Persisted
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #23543.
Backport of #23666.
Backport of #23693.
Backport of #23759.
See those PRs for more details.
Notes: Ensured proper nativeImage serialization between renderer and browser processes via remote.