Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable TLS renegotiation in node #25042

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Aug 19, 2020

Backport of #25022

See that PR for details.

Notes: Fixed node's TLS stack not allowing renegotiation.

@trop trop bot requested a review from electron/wg-upgrades as a code owner Aug 19, 2020
@trop trop bot requested a review from nornagon Aug 19, 2020
@trop trop bot mentioned this pull request Aug 19, 2020
5 of 5 tasks complete
nornagon and others added 2 commits Aug 19, 2020
@codebytere codebytere merged commit cb2fa85 into 8-x-y Aug 20, 2020
16 checks passed
16 checks passed
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@trop
Valid Backport Valid Backport
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
@appveyor
appveyor: win-woa-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm-testing Build #20200819.34 succeeded
Details
@azure-pipelines
electron-arm64-testing Build #20200819.35 succeeded
Details
@azure-pipelines
electron-woa-testing Build #20200819.35 succeeded
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 20, 2020

Release Notes Persisted

Fixed node's TLS stack not allowing renegotiation.

@codebytere codebytere deleted the trop/8-x-y-bp-fix-enable-tls-renegotiation-in-node-1597861129955 branch Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants