Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reply notifs sometimes destroyed too early #25102

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Aug 24, 2020

Backport of #25086

See that PR for details.

Notes: Fixed an issue where notifications with a reply button could potentially be destroyed too early when a user clicked on the notification body before replying.

@trop trop bot requested a review from codebytere Aug 24, 2020
@trop trop bot mentioned this pull request Aug 24, 2020
5 of 5 tasks complete
@codebytere codebytere merged commit 75b9ab7 into 8-x-y Aug 24, 2020
15 of 16 checks passed
15 of 16 checks passed
@azure-pipelines
electron-woa-testing Build #20200824.4 had test failures
Details
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@trop
Valid Backport Valid Backport
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
@appveyor
appveyor: win-woa-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm-testing Build #20200824.1 succeeded
Details
@azure-pipelines
electron-arm64-testing Build #20200824.1 succeeded
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@codebytere codebytere deleted the trop/8-x-y-bp-fix-reply-notifs-sometimes-destroyed-too-early-1598243285508 branch Aug 24, 2020
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 24, 2020

Release Notes Persisted

Fixed an issue where notifications with a reply button could potentially be destroyed too early when a user clicked on the notification body before replying.

MarshallOfSound added a commit that referenced this pull request Oct 21, 2020
This reverts commit 75b9ab7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant