fix: prevent crash if BrowserView webContents was destroyed

[codebytere]

Description of Change

Fixes an issue where interacting with a BrowserWindow which had a BrowserView attached whose webContents had been destroyed could cause a crash in BaseWindow::ResetBrowserViews().

cc @nornagon @MarshallOfSound

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
• This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Release Notes

Notes: none.

[release-clerk]

No Release Notes

[trop]

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

[trop]

@codebytere has manually backported this PR to "10-x-y", please check out #25146

[vladimiry]

@codebytere

This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

The change looks like a breaking change for me since some public methods got removed.

How do I explicitly destroy the BrowserView instance in v11? Does the linked BrowserView isntance get automatically destroyed when I call browserWindow.setBrowserView(null)?

[codebytere]

@vladimiry this PR didn't remove the methods - it just addressed documentation as a follow-up on another PR which did so. However, we do agree with you - the PR which did remove these methods did not align with above stated goals as you point out and the methods will be restored.

[vladimiry]

this PR didn't remove the methods - it just addressed documentation as a follow-up on another PR which did so

Thanks for clarification, I missed looking into that another PR.