Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent crash if BrowserView webContents was destroyed #25146

Closed
wants to merge 2 commits into from
Closed

fix: prevent crash if BrowserView webContents was destroyed #25146

wants to merge 2 commits into from

Conversation

codebytere
Copy link
Member

Backport of #25112.

See that PR for more details.

Notes: none

@codebytere codebytere requested a review from a team August 26, 2020 17:44
@trop trop bot mentioned this pull request Aug 26, 2020
Merged
6 tasks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 26, 2020
@trop trop bot added 10-x-y backport This is a backport PR labels Aug 26, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 26, 2020
jkleinsc
jkleinsc requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes because this is causing a crash in master

@codebytere codebytere requested a review from jkleinsc August 27, 2020 17:57
jkleinsc
jkleinsc requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures on linux and mac seem concerning:
https://app.circleci.com/pipelines/github/electron/electron/29081/workflows/1d191c5c-e4b2-408c-bf86-81c4f327981d/jobs/642432/tests
and
https://app.circleci.com/pipelines/github/electron/electron/29081/workflows/41d791c4-6291-4d89-9ab3-1175740bcead/jobs/642447/tests

@codebytere
Copy link
Member Author

@jkleinsc yeah 🤔 the big difference between 10/11 is this: #23578

@codebytere
Copy link
Member Author

@nornagon might have thoughts on this one - we removed getAllViews() in the above linked PR (for good reason) but that's likely intersecting with this in some weird way i'm not seeing

@codebytere codebytere closed this Aug 31, 2020
@codebytere codebytere deleted the bw-bv-please-no-die-10 branch August 31, 2020 18:14
@codebytere codebytere mentioned this pull request Aug 31, 2020
Merged
@codebytere codebytere mentioned this pull request Sep 24, 2020
Merged
@trop trop bot added the merged/10-x-y label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc requested changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @jkleinsc @MarshallOfSound