Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only focus a webContents if the window was not initially hidden #25323

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 4, 2020

Backport of #25292

See that PR for details.

Notes: Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 4, 2020
@trop trop bot requested a review from MarshallOfSound Sep 4, 2020
@trop trop bot added 11-x-y backport This is a backport PR labels Sep 4, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 4, 2020
@MarshallOfSound MarshallOfSound merged commit c35ec6b into 11-x-y Sep 4, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 4, 2020

Release Notes Persisted

Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false

@MarshallOfSound MarshallOfSound deleted the trop/11-x-y-bp-fix-only-focus-a-webcontents-if-the-window-was-not-initially-hidden-1599202665499 branch Sep 4, 2020
MarshallOfSound added a commit that referenced this pull request Sep 4, 2020
…25323)

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
zcbenz pushed a commit that referenced this pull request Sep 8, 2020
…25323) (#25330)

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants