-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(extensions): define platform info to prevent renderer crash #25357
fix(extensions): define platform info to prevent renderer crash #25357
Conversation
78d6694
to
c2cb2f4
Compare
LGTM |
Looks like you're missing a dependency declaration in the BUILD.gn file:
While it's a little questionable for us to be making a dependency on something called "update client" (given we don't use any of the actual functionality of that component), we're already transitively dependent on it via |
Also, I'm surprised this crashed before. Can you provide some more info about the crash this fixes? |
@nornagon what seems to happen is the API attempts to use |
The Runtime API Delegate relies on values from this component.
908c797
to
6d8ca09
Compare
shell/browser/extensions/api/runtime/electron_runtime_api_delegate.cc
Outdated
Show resolved
Hide resolved
a074271
to
24808d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, LGTM
Release Notes Persisted
|
Description of Change
Fully implements
chrome.runtime.getPlatformInfo
such that the calling renderer won't crash/hang.The implementation is copied from chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc.
Ref #19447
cc @nornagon @sentialx
Checklist
npm test
passesRelease Notes
Notes: Fixed
chrome.runtime.getPlatformInfo
crashing the background process upon being invoked.