Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unsubscribe from observers when window is closing #25584

Merged
merged 1 commit into from
Sep 23, 2020
Merged

fix: unsubscribe from observers when window is closing #25584

merged 1 commit into from
Sep 23, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 23, 2020 •
edited by jkleinsc
Loading

Backport of #25554

See that PR for details.

Notes: fixed unsubscribe from observers when window is closing

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2020
@trop trop bot requested a review from zcbenz September 23, 2020 01:53
@trop trop bot mentioned this pull request Sep 23, 2020
Merged
6 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2020
@jkleinsc jkleinsc merged commit a42a529 into 10-x-y Sep 23, 2020
@jkleinsc jkleinsc deleted the trop/10-x-y-bp-fix-unsubscribe-from-observers-when-window-is-closing-1600826027940 branch September 23, 2020 13:59
@release-clerk
Copy link

release-clerk bot commented Sep 23, 2020 •
edited by jkleinsc
Loading

Release Notes Persisted

fixed unsubscribe from observers when window is closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @zcbenz