fix: fail protocol request when OnWrite fails #26296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
|
This is a user facing change, can you add some release notes for it. LGTM, otherwise. |
|
Added a release note. Wasn't sure how to word it since I'm still not clear on what condition would trigger it to begin with. 😆 I kept it generic. |
|
Haha nice I respect that. I’m clueless about how to get even started to use electron for my web dev. Any shortcuts or guides y’all could recommend would be of real help
… On Nov 2, 2020, at 2:05 PM, David Sanders ***@***.***> wrote:
Added a release note. Wasn't sure how to word it since I'm still not clear on what condition would trigger it to begin with. 😆 I kept it generic.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#26296 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJT2PIGCFBUTUZEQUAHVFILSN37GBANCNFSM4TGL3J2A>.
|
deepak1556
approved these changes
Nov 2, 2020
codebytere
approved these changes
Nov 2, 2020
zcbenz
approved these changes
Nov 3, 2020
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Wasn't sending a failed response for a protocol request in an error case, could have left the request without a response. I don't know of a way to easily test this, wasn't able to trigger it, seems like a corner-case.
Checklist
npm testpassesRelease Notes
Notes: fixed error handling on write failure in the protocol module