Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set presentationModeEnabled value for PDF viewer #27223

Merged
merged 1 commit into from
Jan 11, 2021
Merged

fix: set presentationModeEnabled value for PDF viewer #27223

merged 1 commit into from
Jan 11, 2021

Conversation

codebytere
Copy link
Member

Description of Change

Fixes the following error seen when loading PDFs:

[74831:0107/104235.588122:INFO:CONSOLE(222)] "Unexpected condition on chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html: Could not find value for presentationModeEnabled", source: chrome://resources/js/load_time_data.m.js (222)
[74831:0107/104235.588212:INFO:CONSOLE(222)] "Unexpected condition on chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html: [undefined] (presentationModeEnabled) is not a boolean", source: chrome://resources/js/load_time_data.m.js (222)

cc @MarshallOfSound @jkleinsc

Checklist

Release Notes

Notes: Fix missing presentation mode option in PDF viewer.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 7, 2021
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Jan 9, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 9, 2021
@zcbenz zcbenz merged commit e74b425 into master Jan 11, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 11, 2021

Release Notes Persisted

Fix missing presentation mode option in PDF viewer.

@zcbenz zcbenz deleted the add-missing-presentationmodeenabled branch January 11, 2021 01:48
@trop trop bot mentioned this pull request Jan 11, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Jan 11, 2021

I have automatically backported this PR to "12-x-y", please check out #27262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @jkleinsc @zcbenz