-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support registering MV3 extension service workers #27562
feat: support registering MV3 extension service workers #27562
Conversation
schemes->secure_schemes.push_back(extensions::kExtensionScheme); | ||
schemes->service_worker_schemes.push_back(extensions::kExtensionScheme); | ||
schemes->cors_enabled_schemes.push_back(extensions::kExtensionScheme); | ||
schemes->csp_bypassing_schemes.push_back(extensions::kExtensionScheme); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these schemes are added in ChromeContentClient::AddAdditionalSchemes
@@ -118,9 +118,6 @@ RendererClientBase::RendererClientBase() { | |||
ParseSchemesCLISwitch(command_line, switches::kSecureSchemes); | |||
for (const std::string& scheme : secure_schemes_list) | |||
url::AddSecureScheme(scheme.data()); | |||
// In Chrome we should set extension's origins to match the pages they can | |||
// work on, but in Electron currently we just let extensions do anything. | |||
url::AddSecureScheme(extensions::kExtensionScheme); | |||
// We rely on the unique process host id which is notified to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was able to be removed as it's now included in the --secure-schemes=scheme1,scheme2
switch.
19381dc
to
62fca99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Merging as CI failure is known flake |
Release Notes Persisted
|
Description of Change
Manifest V3 (MV3) has become generally available in M88 Beta.
This adds the bare minimum in order to run MV3's new service workers meant to replace MV2's background processes.
A new
registration-completed
event is added toSession.serviceWorkers
for testing whether extension service workers register properly.cc @electron/wg-api
Checklist
npm test
passesRelease Notes
Notes:
ServiceWorkers
.