feat: support registering MV3 extension service workers #27562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmaddock
commented
Jan 31, 2021
| schemes->secure_schemes.push_back(extensions::kExtensionScheme); | ||
| schemes->service_worker_schemes.push_back(extensions::kExtensionScheme); | ||
| schemes->cors_enabled_schemes.push_back(extensions::kExtensionScheme); | ||
| schemes->csp_bypassing_schemes.push_back(extensions::kExtensionScheme); |
There was a problem hiding this comment.
All of these schemes are added in ChromeContentClient::AddAdditionalSchemes
| @@ -118,9 +118,6 @@ RendererClientBase::RendererClientBase() { | |||
| ParseSchemesCLISwitch(command_line, switches::kSecureSchemes); | |||
| for (const std::string& scheme : secure_schemes_list) | |||
| url::AddSecureScheme(scheme.data()); | |||
| // In Chrome we should set extension's origins to match the pages they can | |||
| // work on, but in Electron currently we just let extensions do anything. | |||
| url::AddSecureScheme(extensions::kExtensionScheme); | |||
| // We rely on the unique process host id which is notified to the | |||
There was a problem hiding this comment.
This was able to be removed as it's now included in the --secure-schemes=scheme1,scheme2 switch.
samuelmaddock
force-pushed
the
feat/mv3-extension-sw
branch
from
19381dc
to
62fca99
Compare
nornagon
reviewed
Feb 2, 2021
zcbenz
approved these changes
Feb 3, 2021
nornagon
approved these changes
Feb 3, 2021
jkleinsc
added
semver/minor
electron-cation
bot
added
api-review/requested 🗳
and removed
new-pr 🌱
electron-cation
bot
added
api-review/requested 🗳
and removed
api-review/approved ✅
labels
|
Merging as CI failure is known flake |
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Manifest V3 (MV3) has become generally available in M88 Beta.
This adds the bare minimum in order to run MV3's new service workers meant to replace MV2's background processes.
A new
registration-completedevent is added toSession.serviceWorkersfor testing whether extension service workers register properly.cc @electron/wg-api
Checklist
npm testpassesRelease Notes
Notes:
ServiceWorkers.