Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow accessing file:// when web security is disabled #28560

Merged
merged 3 commits into from
Apr 9, 2021
Merged

fix: allow accessing file:// when web security is disabled #28560

merged 3 commits into from
Apr 9, 2021

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Apr 7, 2021

Backport of #28489

See that PR for details.

Notes: Fix failing to request file:// resources when web security is disabled.

@trop trop bot mentioned this pull request Apr 7, 2021
Merged
5 tasks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 7, 2021
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 7, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 7, 2021
@zcbenz zcbenz merged commit 274f6f7 into 12-x-y Apr 9, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 9, 2021

Release Notes Persisted

Fix failing to request file:// resources when web security is disabled.

@zcbenz zcbenz deleted the fix-request-file-protocol-12 branch April 9, 2021 00:46
@trop
Copy link
Contributor

trop bot commented Apr 9, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/11-x-y label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @jkleinsc