chore: bump Node.js to v16.2.0

[codebytere]

Description of Change

Upgrading Node.js to v16.2.0. A work in progress, which ideally will go out in Electron v14.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: : Updated Node.js to v16.2.0.

[ckerr]

Mostly LGTM. This is looking good. +1 on Jeremy's comments about crypto.

Also I lean towards Anna's idea upstream about finding a way to handle unhandled exceptions without adding new undocumented API. Also, I I'm still curious why it's needed, so one nit on this PR might be to update the patch comment to add more background explaining that 🙂

[ckerr]

@codebytere I'm curious about this too. What's prompting this patch?

[codebytere]

@ckerr @nornagon in v15 Node.js made a change such that unhandled rejections exit/crash the process. I introduced this patch because I think this behavior isn't appropriate for all Electron processes, and that we instead want to selectively enable it. For example, I think that this behavior is fine/expected in ELECTRON_RUN_AS_NODE, but that an unhandled rejection shouldn't crash the renderer process.

[MarshallOfSound]

Also I lean towards Anna's idea upstream about finding a way to handle unhandled exceptions without adding new undocumented API

To clarify this, the "undocumented API" is internal to NodeJS in cpp land, there's no public facing API here from Electrons perspective.

Do we not? Why do we want to differ from node in this regard?

To answer this question though, we already differ from Node in regards to global error handling for precisely the reasons @codebytere outlined above. What is expected behavior for a NodeJS script / server is entirely unexpected for a desktop application. One unhandled rejection / exception should not pull the entire app down.

That's actually why we have this global uncaughtException handler which prevents nodes default behavior of bringing down the process because by default in electron that error is handled.

The approach we took here is slightly different (rather we made the unhandled rejection behavior it's old-form which people expect) but an equivalent solution would be to add a similar global unhandledRejection listener such that all rejections are "handled" still.

The TLDR here is expectations of unhandled errors are fundamentally different between desktop apps and node scripts.

[nornagon]

lgtm overall, v happy to see all the upstreamed crypto stuff!

[release-clerk]

Release Notes Persisted

: Updated Node.js to v16.2.0.