fix: don't double-log unhandled rejections #37464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #36829.
Switches from unhandled rejection style from
warn
towarn-with-error-code
. Thewarn
mode always triggers a warning, no matter if theunhandledRejection
hook is set or not - this isn't really intuitive behavior. We added this initially in #29244, because Node.js themselves switched their unhandled rejection behavior to throw by default and we didn't want unhandled rejections to crash the main or renderer processes.warn-with-error-code
now only warns if the error is not handled with theunhandledRejection
hook - it also sets the process exit code to 1, but this doesn't affect Electron as it sets its own exit code.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where unhandled rejections could cause duplicate logs in some cases.