fix: properly order out child windows on window.hide()

[codebytere]

Description of Change

Closes #29820.

Properly orders out child windows when window.hide() is called on a parent window. This should not change any end user behavior, but Chromium specifically DCHECKs for it so we should handle it properly.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: none.

[MarshallOfSound]

Hm if I'm reading this right this is an annoying behavior change, where you can't open a child window and have it remain visible while hiding the parent. (E.g. Think about a certain app that has a calls window it opens as a child and then hides the parent).

Not sure what the correct solution is here but this will definitely affect existing apps

[codebytere]

@MarshallOfSound I thought so too, but this behavior is the same for end users at present - if you add for example

const child = new BrowserWindow({
    width: 200,
    height: 200,
    parent: mainWindow
  })

  child.show()
  setTimeout(() => {
    mainWindow.hide()
  }, 5000)

to the default fiddle and run with e.g. 12.0.10 you'll see that when the setTimeout callback executes, both windows are hidden. Also, if you don't set the timeout and run:

child.show()
mainWindow.hide()

you end up with a ghost main window (look at the transparent window):

which this PR also ameliorates.

[zcbenz]

I'm 👍 with this since it is fixing a DCHECK in Chromium.

[codebytere]

Crash report failure is not relevant.

[release-clerk]

No Release Notes

[trop]

I have automatically backported this PR to "12-x-y", please check out #29887

[trop]

I have automatically backported this PR to "13-x-y", please check out #29888

[trop]

I have automatically backported this PR to "14-x-y", please check out #29889