Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: process.exit crash in nativeWindowOpen #30235

Merged
merged 3 commits into from
Jul 22, 2021
Merged

fix: process.exit crash in nativeWindowOpen #30235

merged 3 commits into from
Jul 22, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 22, 2021

Backport of #30218

See that PR for details.

Notes: Fixed a crash when process.exit is called and nativeWindowOpen is enabled.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 22, 2021
@trop trop bot requested a review from codebytere July 22, 2021 13:38
@trop trop bot mentioned this pull request Jul 22, 2021
Merged
4 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 22, 2021
@jkleinsc
Copy link
Contributor

Merging as CI failure is unrelated to PR change.

@jkleinsc jkleinsc merged commit 407a005 into 14-x-y Jul 22, 2021
@jkleinsc jkleinsc deleted the trop/14-x-y-bp-fix-process-exit-crash-in-nativewindowopen-1626961102832 branch July 22, 2021 16:15
@release-clerk
Copy link

release-clerk bot commented Jul 22, 2021

Release Notes Persisted

Fixed a crash when process.exit is called and nativeWindowOpen is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @codebytere