Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use contentAspectRatio in setAspectRatio() on macOS #30330

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 29, 2021

Backport of #30305

See that PR for details.

Notes: Fixes an issue where a specified aspect ratio could become incorrect when maximizing a window on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2021
@trop trop bot requested a review from codebytere July 29, 2021 21:28
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 29, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2021
@zcbenz zcbenz merged commit 6627beb into 13-x-y Aug 2, 2021
@zcbenz zcbenz deleted the trop/13-x-y-bp-fix-use-contentaspectratio-in-setaspectratio-on-macos-1627594060616 branch August 2, 2021 00:59
@release-clerk
Copy link

release-clerk bot commented Aug 2, 2021

Release Notes Persisted

Fixes an issue where a specified aspect ratio could become incorrect when maximizing a window on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants