Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to crashpad on linux #30384

Closed
wants to merge 6 commits into from
Closed

feat: switch to crashpad on linux #30384

wants to merge 6 commits into from

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 3, 2021

Backport of #30278

See that PR for details.

Notes: The crashReporter API is now powered by Crashpad on Linux.

@trop trop bot requested a review from a team as a code owner August 3, 2021 21:01
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 3, 2021
@trop trop bot requested a review from nornagon August 3, 2021 21:01
@trop trop bot mentioned this pull request Aug 3, 2021
Merged
5 tasks
@trop trop bot added 15-x-y backport This is a backport PR backport/requested 🗳 semver/major incompatible API changes labels Aug 3, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 3, 2021
@timfish
Copy link
Contributor

timfish commented Aug 3, 2021

@nornagon if this a backport to v15 does that mean it will become the default for v15 rather than behind a command line switch?

@nornagon
Copy link
Member

nornagon commented Aug 3, 2021 •
edited

@timfish yes, that's accurate, & matches the plan I posted here: #27859 (comment)

@nornagon
Copy link
Member

nornagon commented Aug 3, 2021

Er, sorry, I misread the plan I posted. I said we'd make it available in 15 and switch it on by default in 16. I'm going to close this PR then! Thanks for the nudge.

@nornagon nornagon closed this Aug 3, 2021
@trop trop bot deleted the trop/15-x-y-bp-feat-switch-to-crashpad-on-linux-1628024482397 branch August 3, 2021 21:56
@timfish
Copy link
Contributor

timfish commented Aug 3, 2021

The last comment in the issue you linked to says:

In Electron 16, we will remove this switch and only support Crashpad.

This PR suggests this will in fact happen for v15 and there won't be any major releases where the command line switch will be required to use crashpad on Linux.

Either way 👌

@nornagon
Copy link
Member

nornagon commented Aug 3, 2021

@timfish yeah, see my followup above!

@nornagon
Copy link
Member

nornagon commented Aug 3, 2021

Also, #30387

@timfish
Copy link
Contributor

timfish commented Aug 3, 2021

That's one of the problems with late night GitHub on the mobile app. Seemingly no live updates yet 😂

Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
15-x-y backport/requested 🗳 backport This is a backport PR semver/major incompatible API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timfish @nornagon