-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to crashpad on linux #30278
Conversation
NB, the linux and mac CI failures are not flake, but are not related to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
For the release notes, it is probably worth calling out explicitly which behaviors will change with the migration to Crashpad. The most likely impact I would suggest mentioning is that the default storage path is changing. For apps that have additional tooling or customer support workflows that involve retrieving those raw crash dumps, it would be good to provide a heads up.
@itsananderson do you think that should go in |
Sorry, I forgot to respond, but yes breaking changes sounds good. |
Release Notes Persisted
|
I have automatically backported this PR to "15-x-y", please check out #30384 |
Description of Change
This enables crashpad by default on Linux, matching Chrome.
Closes #27859.
Checklist
npm test
passesRelease Notes
Notes: The
crashReporter
API is now powered by Crashpad on Linux.