-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add <webview>.sendToFrame() / frameId to 'ipc-message' event #30451
Conversation
3a560c2
to
e70b3b4
Compare
e70b3b4
to
671fdff
Compare
webview.sendToFrame with passing in the frameId looks good to me! |
671fdff
to
699982f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
699982f
to
bb0b2e6
Compare
@codebytere conflicts resolved |
API LGTM. button click is a bit pointless b/c it gets reset by any rebase or other change. |
@codebytere can we merge this now? |
fc660e5
to
e6eb812
Compare
Release Notes Persisted
|
I was unable to backport this PR to "15-x-y" cleanly; |
Description of Change
This allows replying to an IPC sent by a frame (when
nodeIntegrationInSubFrames
is enabled) inside of the<webview>
:Fixes #30207.
Checklist
npm test
passesRelease Notes
Notes: Added
<webview>.sendToFrame()
/frameId
to'ipc-message'
event.