Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix pylint #31138

Merged
merged 2 commits into from
Sep 29, 2021
Merged

chore: fix pylint #31138

merged 2 commits into from
Sep 29, 2021

Conversation

alexeykuzmin
Copy link
Contributor

@alexeykuzmin alexeykuzmin commented Sep 27, 2021 •
edited
Loading

Description of Change

Subj.
Here's a lint run with all found errors:
https://app.circleci.com/pipelines/github/electron/electron/45054/workflows/8ee71f42-9878-4597-ace4-38d604602cea/jobs/1015610

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2021
@alexeykuzmin alexeykuzmin requested a review from a team as a code owner September 27, 2021 14:37
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2021
ckerr
ckerr approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS CI failure is unrelated to this PR

@jkleinsc jkleinsc merged commit 2d111a4 into electron:main Sep 29, 2021
@release-clerk
Copy link

release-clerk bot commented Sep 29, 2021

No Release Notes

@alexeykuzmin alexeykuzmin deleted the fix-pylint branch September 30, 2021 09:24
@alexeykuzmin alexeykuzmin mentioned this pull request Sep 30, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Sep 30, 2021

@alexeykuzmin has manually backported this PR to "16-x-y", please check out #31201

@alexeykuzmin alexeykuzmin mentioned this pull request Sep 30, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Sep 30, 2021

@alexeykuzmin has manually backported this PR to "15-x-y", please check out #31207

@commit-lint commit-lint bot mentioned this pull request Jan 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexeykuzmin @ckerr @jkleinsc @codebytere @miniak