Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f781748dcb3c from chromium #32257

Merged
merged 2 commits into from Jan 3, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Dec 20, 2021

Show the origin of the last redirecting server in external protocol handler dialogs

External protocol handlers always show the initiating url's origin. This can be misleading if there are server side redirects.
Now we will show the origin of the last redirecting server (falling back to the request_initiator if there were no redirects / if the request goes straight to an external protocol).

Bug: 1197889
Change-Id: I3cf7ccf3a8bd79d161364680a1871d1c88bec813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3113931
Commit-Queue: Ravjit Singh Uppal ravjit@chromium.org
Reviewed-by: Arthur Sonzogni arthursonzogni@chromium.org
Reviewed-by: Collin Baker collinbaker@chromium.org
Reviewed-by: Takashi Toyoshima toyoshim@chromium.org
Reviewed-by: Łukasz Anforowicz lukasza@chromium.org
Cr-Commit-Position: refs/heads/main@{#922096}

Notes: Backported fix for CVE-2021-38018.

@ppontes ppontes requested a review from as a code owner Dec 20, 2021
@electron-cation electron-cation bot added the new-pr 🌱 label Dec 20, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 27, 2021
@codebytere codebytere added 15-x-y backport-check-skip semver/patch labels Jan 3, 2022
@jkleinsc jkleinsc merged commit f74940b into 15-x-y Jan 3, 2022
15 checks passed
@jkleinsc jkleinsc deleted the cherry-pick/15-x-y/chromium/f781748dcb3c branch Jan 3, 2022
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 3, 2022

Release Notes Persisted

Backported fix for CVE-2021-38018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants