Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing comma in config.py #32666

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix: Missing comma in config.py #32666

merged 1 commit into from
Jan 31, 2022

Conversation

mrshu
Copy link
Contributor

@mrshu mrshu commented Jan 28, 2022

Description of Change

  • Fix missing comma

Checklist

I believe this is a minimal change

Release Notes

Notes: none.

* Fix missing comma
@welcome
Copy link

welcome bot commented Jan 28, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 28, 2022
@miniak
Copy link
Contributor

miniak commented Jan 30, 2022

@nornagon the comma was lost in #32540

@codebytere codebytere added target/17-x-y semver/patch backwards-compatible bug fixes labels Jan 31, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2022
@codebytere
Copy link
Member

Unrelated failure - merging.

@codebytere codebytere merged commit c6d061c into electron:main Jan 31, 2022
@welcome
Copy link

welcome bot commented Jan 31, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jan 31, 2022

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jan 31, 2022

I have automatically backported this PR to "15-x-y", please check out #32676

@trop
Copy link
Contributor

trop bot commented Jan 31, 2022

I have automatically backported this PR to "16-x-y", please check out #32677

@trop
Copy link
Contributor

trop bot commented Jan 31, 2022

I have automatically backported this PR to "17-x-y", please check out #32678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants