Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webContents.printToPDF option plumbing #35975

Merged
merged 1 commit into from Oct 11, 2022
Merged

fix: webContents.printToPDF option plumbing #35975

merged 1 commit into from Oct 11, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Closes #35971.

Fixes some incorrect options plumbing in webContents.printToPDF()

Tested with https://gist.github.com/lesleyandreza/7699603b20f2459d1fcf3b9480fb22e1

Checklist

Release Notes

Notes: Fixed an issue where some options were incorrectly ignored when using webContents.printToPDF().

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Oct 11, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 11, 2022
@codebytere codebytere mentioned this pull request Oct 11, 2022
Merged
4 tasks
@MarshallOfSound MarshallOfSound merged commit ee7cf5a into main Oct 11, 2022
@MarshallOfSound MarshallOfSound deleted the fix-pdf-options branch October 11, 2022 23:06
@release-clerk
Copy link

release-clerk bot commented Oct 11, 2022

Release Notes Persisted

Fixed an issue where some options were incorrectly ignored when using webContents.printToPDF().

This was referenced Oct 11, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 11, 2022

I have automatically backported this PR to "21-x-y", please check out #35992

@trop trop bot added in-flight/21-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. labels Oct 11, 2022
@trop
Copy link
Contributor

trop bot commented Oct 11, 2022

I have automatically backported this PR to "22-x-y", please check out #35993

@trop trop bot added in-flight/22-x-y merged/22-x-y PR was merged to the "22-x-y" branch. merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/22-x-y labels Oct 11, 2022
@commit-lint commit-lint bot mentioned this pull request Feb 6, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: webContents.printToPDF option plumbing (electron#35975)
eb0caeb 
fix: contents.printToPDF option plumbing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Some options of printToPDF don't work
3 participants
@codebytere @jkleinsc @MarshallOfSound