refactor: enable OOPIF printing to PDF #36051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
slimmer_printing
branch
from
31c2384
to
0941781
Compare
codebytere
force-pushed
the
slimmer_printing
branch
from
0941781
to
2c766a3
Compare
zcbenz
approved these changes
Oct 18, 2022
3 tasks
codebytere
force-pushed
the
slimmer_printing
branch
from
2c766a3
to
6c307ef
Compare
jkleinsc
approved these changes
Oct 20, 2022
|
|
Release Notes Persisted
|
|
I was unable to backport this PR to "21-x-y" cleanly; |
trop
bot
added
needs-manual-bp/21-x-y
and removed
target/21-x-y
|
I have automatically backported this PR to "22-x-y", please check out #36095 |
trop
bot
added
in-flight/22-x-y
merged/22-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs CL:3780384 and CL:3805932
Refactor
PrintViewManagerElectronto take advantage of changes made in CL:3780384 and CL:3805932. Specifically - offload PDF print jobs to a newly addedcomponents/printing/browser/print_to_pdf/pdf_print_job.{h|cc}class. This also enables PDF composition support to allow OOPIF printing to PDF.Tested with:
Checklist
npm testpassesRelease Notes
Notes: Enabled out-of-process iframe printing to PDF with
webContents.printToPDF()..