refactor: move draggable regions to WebContents #36230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
5 tasks
zcbenz
approved these changes
Nov 7, 2022
|
|
||
| void NativeWindow::AddDraggableRegionProvider( | ||
| DraggableRegionProvider* provider) { | ||
| if (std::find(draggable_region_providers_.begin(), |
There was a problem hiding this comment.
Maybe just use std::set for draggable_region_providers_ to avoid duplicate items?
There was a problem hiding this comment.
The reason I chose std::list is to preserve ordering. I'm not sure if this really matters, but to be safe, I wanted it to be that the draggable region providers were checked in the order they were inserted.
|
No Release Notes |
3 tasks
3 tasks
3 tasks
3 tasks
MarshallOfSound
added a commit
that referenced
this pull request
Feb 21, 2023
This reverts commit 184ac2b.
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
3 tasks
Open
3 tasks
3 tasks
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Following up from #35007, reapplying the refactors in #35603 and further moving
the draggable regions towards what they're most "tightly" bound to, i.e. the
WebContents.
Checklist
npm testpassesRelease Notes
Notes: none