fix: resizing borders in nondraggable regions #37016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
zcbenz
reviewed
Jan 26, 2023
zcbenz
approved these changes
Jan 26, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "23-x-y", please check out #37037 |
trop
bot
added
in-flight/23-x-y
merged/23-x-y
MarshallOfSound
added a commit
that referenced
this pull request
Feb 21, 2023
This reverts commit 0026fdb.
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: resizing borders in nondraggable regions * chore: remove frame handling from ShouldDescendIntoChildForEventHandling
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
* fix: resizing borders in nondraggable regions * chore: remove frame handling from ShouldDescendIntoChildForEventHandling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37008.
Refs #36230.
The above refactor improved draggable regions by typing them most closely to WebContents, but introduced an issue whereby draggable regions could take precedence over resizing borders on Windows. This was happening as a result of
NativeWindow::NonClientHitTest, which returned the first non-HTNOWHERE value it found. This meant that the window's border coordinates would not take appropriate precedence, and instead ofHTBOTTOM,HTLEFT, etc being returned for the window edge coordinates,HTCAPTIONwould instead be returned and the window bordered rendered useless. We fix this by first checkingResizingBorderHitTestresults inNativeWindow::NonClientHitTestand proceeding to draggable region calculations if we are not on a resizing window border.Tested with https://gist.github.com/takumus/9054bde77c8206143232fed2659bf108
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where some frameless windows with draggable regions were not resizable on Windows.