Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't use pull_request_target with semantic PR title check #37745

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

dsanders11
Copy link
Member

Description of Change

pull_request_target has sharp edges like granting access to secrets so it shouldn't be used unless necessary. pull_request should work fine here.

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding pull_request_target is only necessary when we need read/write permissions on forks, which isn't relevant here, so this seems fine to me too!

@nornagon nornagon merged commit 835ace2 into main Mar 29, 2023
@nornagon nornagon deleted the semantic-title-check-tweak branch March 29, 2023 21:28
@release-clerk
Copy link

release-clerk bot commented Mar 29, 2023

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants