refactor: use compile-time cli arg sets. #38748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently building these on the heap with `std::set<std::string>` but this can be a very small compile-time container instead. Marking as 'refactor' rather than 'perf' since this isn't called often, but moving from heap to compile-time is good and using this container makes the code more readable.
ckerr
added
semver/patch
codebytere
approved these changes
Jun 13, 2023
zcbenz
approved these changes
Jun 13, 2023
|
No Release Notes |
This was referenced Jun 13, 2023
|
I have automatically backported this PR to "25-x-y", please check out #38768 |
trop
bot
added
in-flight/25-x-y
and removed
target/25-x-y
|
I have automatically backported this PR to "26-x-y", please check out #38769 |
|
I have automatically backported this PR to "24-x-y", please check out #38770 |
trop
bot
added
in-flight/26-x-y
in-flight/24-x-y
merged/24-x-y
trop
bot
added
merged/25-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
We're currently building these on the heap with `std::set<std::string>` but this can be a very small compile-time container instead. Marking as 'refactor' rather than 'perf' since this isn't called often, but moving from heap to compile-time is good and using this container makes the code more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We're currently building these on the heap with
std::set<std::string>but this can be a very small compile-time container instead. (Discussion ofbase::fixed_flat_mapandbase::fixed_flat_sethere.)Marking as 'refactor' rather than 'perf' since this isn't called often, but moving from heap to compile-time is good and using this container makes the code more readable.
CC: @dsanders11 who showed interest in string -> StringPiece conversion and @codebytere as the primary for the functions changed here, but code review welcome from anyone
Checklist
npm testpassesRelease Notes
Notes: none